Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use port of redirect uri in credential file to run local server in GoogleDocsReader #16327

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Use port of redirect uri in credential file to run local server in GoogleDocsReader #16327

merged 3 commits into from
Oct 17, 2024

Conversation

xwind-h
Copy link
Contributor

@xwind-h xwind-h commented Oct 2, 2024 •
edited
Loading

Description

Get the port from redirect URI in credential file, and use it to run local server.

Fixes # 16326

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 2, 2024
anoopshrma
anoopshrma reviewed Oct 3, 2024
View reviewed changes
...ndex-integrations/readers/llama-index-readers-google/llama_index/readers/google/docs/base.py Outdated
@@ -112,7 +113,15 @@ def _get_credentials(self) -> Any:
flow = InstalledAppFlow.from_client_secrets_file(
"credentials.json", SCOPES
)
creds = flow.run_local_server(port=0)

port = 8080
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Would you mind putting this maybe at the top of this method.

Or maybe declare this as a class variable 🤔

Copy link
Contributor Author

@xwind-h xwind-h Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Please check it again.

@anoopshrma
Copy link
Collaborator

Would you also check linting, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) October 14, 2024 19:02
@logan-markewich logan-markewich merged commit cf2d78e into run-llama:main Oct 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopshrma anoopshrma anoopshrma approved these changes

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xwind-h @anoopshrma @logan-markewich